Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATATABLES_ERROR shouldn't be by default null #1805 #1811

Merged
merged 2 commits into from
Oct 5, 2018

Conversation

zeyad82
Copy link
Contributor

@zeyad82 zeyad82 commented Aug 2, 2018

No description provided.

zeyad82 added 2 commits August 2, 2018 19:26
To avoid showing any unwanted errors in production if debug is false, we throw an exception and let laravel handle it if error is null and debug is false.
@yajra
Copy link
Owner

yajra commented Aug 18, 2018

Maybe we can just set the default config to throw or maybe custom message?

https://github.com/yajra/laravel-datatables/blob/8.0/src/config/datatables.php#L73

@yajra yajra merged commit 9345892 into yajra:8.0 Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants