[8.0] Allow boolean values for column[i].searchable #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dt Request is sent as application/json instead of multipart/form-data and when in ColumnDef boolean values are used the search does not work. (Angular 6 HTTPClient for example) might affect #1789
Closed
yajra
changed the title
|
Wew, sorry for overlooking this PR for so long. Looks good. Thanks! |
|
Released on v8 and v9. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dt Request is sent as application/json instead of multipart/form-data
and when in ColumnDef boolean values are used the search does not work.
Did not work
column[i].searchable = true;
Did work
column[i].searchable = 'true';
But the type of searchable is boolean according to
https://datatables.net/reference/option/columns.searchable
might affect #1789