Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to pass an array of needed columns and get only them in response, to not add or remove them one by one #1860

Merged
merged 12 commits into from
Oct 5, 2018

Conversation

ptuchik
Copy link
Contributor

@ptuchik ptuchik commented Sep 28, 2018

Example DataTables::of($items)->only(['id', 'name'])->make(true)

@yajra
Copy link
Owner

yajra commented Sep 29, 2018

The idea looks fine. Can you please remove the new line on doc blocks. Thanks!

@ptuchik
Copy link
Contributor Author

ptuchik commented Sep 29, 2018

The idea looks fine. Can you please remove the new line on doc blocks. Thanks!

Thanks for approving the idea. I have removed the new lines in doc blocks

Added exceptions for 'DT_RowId', 'DT_RowClass', 'DT_RowData', 'DT_RowAttr'
Removed unneeded space after removing $exceptions from flatten() function
@ptuchik
Copy link
Contributor Author

ptuchik commented Oct 4, 2018

Hi, are there any updates? I really need this. Thank you

@yajra
Copy link
Owner

yajra commented Oct 5, 2018

Thanks for the updates, will try to review later this evening.

@yajra yajra merged commit 6b263eb into yajra:8.0 Oct 5, 2018
@yajra
Copy link
Owner

yajra commented Oct 5, 2018

Released on v8.9.0 🚀 thanks!

@yajra
Copy link
Owner

yajra commented Oct 5, 2018

BTW, if you can, please submit also a PR on docs and a tests if possible. 🍻

@ptuchik
Copy link
Contributor Author

ptuchik commented Oct 5, 2018

Thank you for update, I will create docs and tests PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants