[BC] Fix the default name of index column to follow DT syntax. #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharifzadesina
force-pushed
the
8.0-index-column-fixed
branch
from
8192229 to
fc110d8
Compare
sharifzadesina
force-pushed
the
8.0-index-column-fixed
branch
from
fc110d8 to
d1c9f64
Compare
|
I think this is breaking change but necessary since I think we can consider this as a bug fix. On the other hand, It will not break only if they have published the config. Or just revert the old name by publishing and editing the value on config file. |
yajra
changed the title
|
BTW, I think this should also be implemented on https://github.com/yajra/laravel-datatables-html/blob/3.0/src/Html/Builder.php#L472. |
|
Will wait until weekend to see if some users have comments on this. If no reactions, I'm ok to release this next week. Thanks! |
jaydons
added a commit
to jaydons/laravel-datatables-html
that referenced
this pull request
Oct 30, 2018
This was referenced Nov 13, 2018
yajra
added a commit
to yajra/laravel-datatables-docs
that referenced
this pull request
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR that changes the name of the index column to follow DT syntax.
DT syntax for special columns is like:
DT_NameNameBut the name of the index column was
DT_Name_NameI don't know this is a breaking change or no cause I only changed the default value.