Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Add simple pagination api. #1911

Merged
merged 4 commits into from
Nov 20, 2018
Merged

[8.0] Add simple pagination api. #1911

merged 4 commits into from
Nov 20, 2018

Conversation

yajra
Copy link
Owner

@yajra yajra commented Nov 20, 2018

Add simplePagination() api for better performance when using large datasets. Simple pagination will skip the recordsTotal count query and will set the value always equal to recordsFiltered.

May address the following performance issues as listed on https://github.com/yajra/laravel-datatables/issues?utf8=%E2%9C%93&q=is%3Aissue+label%3Aperformance+.

To use, simply add ->simplePagination() to your dataTables chain method.

@yajra yajra changed the title Add simple pagination api. [8.0] Add simple pagination api. Nov 20, 2018
@yajra yajra merged commit d6d68ad into 8.0 Nov 20, 2018
@yajra yajra deleted the simple-pagination branch November 20, 2018 03:42
yajra added a commit to yajra/laravel-datatables-docs that referenced this pull request Nov 20, 2018
@yajra
Copy link
Owner Author

yajra commented Nov 20, 2018

Got too excited, use ->skipTotalRecords() instead for better method name. See #1912.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant