[8.0] Added optional merge of config raw columns to rawColumns method #1960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows the optional merging of the raw columns defined in the config, and any new ones that you may want to add.
From my point of view, it seems odd that rawColumns was removing the ones defined in config, we use the ones defined on config as default across all tables, e.g. actions, so setting rawColumn(['state']) caused actions to disappear.
The pull request is written for backwards compatiblity, it won't merge unless true is passed.
Example:
In config
Existing functionality
Results in raw columns as just state, the action column is no longer a raw column.
New merge functionality
Results in raw columns as state and action.
A variation in this idea could be a new method rawColumnsMerge, so existing method is left alone, and a new that just does merge could be used.