[9.0] Add support for self join relationships. #2051

Morinohtar · 2019-04-10T16:21:31Z

A fix for the issue #2045 . It only addresses the "BelongsTo". I did not touch the rest of the relations, so a more complete "fix" can be made.

I also replaced the deprecated function "assertContains" with "assertStringContainsString" in the QueryDataTableTest.

I ran the tests and nothing exploded :P

…ith assertStringContainsString.

yajra

The PR looks good with some DB compatibility issues. Will try to test this on actual project and get back to this as soon as I can. Thanks!

yajra · 2019-04-11T01:46:42Z

src/EloquentDataTable.php

@@ -169,19 +169,23 @@ protected function joinEagerLoadedColumn($relation, $relationColumn)

                case $model instanceof BelongsTo:
                    $table     = $model->getRelated()->getTable();
+                    $alias     = "alias_{$index}_{$table}";
+                    $tableAs   = "{$table} AS $alias";


This will break some installations with Oracle database. Please use "{$table} $alias" removing the AS from query.

But if i remove the AS then MySQL won't work... ok, i managed something, update coming soon.

Can you run your tests again now?

Sorry but your previous PR version is much better. AFAIK, it should work on MySQL since that is one of the reasons why I created this package version to work on Oracle.

On the other hand, I think I already created a patch that properly translates Oracle AS query. Will review with my other package https://github.com/yajra/laravel-oci8 too.

So, what now? You want the first one again?

…ver.

yajra · 2019-04-15T02:53:05Z

src/EloquentDataTable.php

@@ -38,6 +45,9 @@ public function __construct($model)
        parent::__construct($builder->getQuery());

        $this->query = $builder;
+
+        $connection   = config('database.default');


There are cases where the connection is set from the model or via runtime using query. This is will not work on those situations.

Ok, sure. But in your earlier reply (#2051 (comment)) you said, basically, this wouldnt even be necessary. So, what now?

Yes, so please revert the commits to 1st one you sent. Might be able to test this within the week. Thanks!

Ok, done. Sorry for the mess with the commits.

yajra · 2019-04-24T03:27:47Z

This also fixes a lot of issues: [#2045], [#2054], [#2024], [#1977], [#880], [#577], [#522], etc.

Thanks a lot 🚀 released on v9.1.0 🍻

amrmahrous · 2019-04-25T09:05:56Z

please consider the soft delete , the new release cause an error "cloumn related_table.deleted_at not fount in where clause" however it shall be related_table_0_deleted_at

I rollback back to 9.0.1 and it works just perfect .

thank you for the great work , this project helps me a lot making fast delevlopment !

yajra · 2019-04-26T08:26:47Z

Reverting due to unseen breaking change on soft deletes.

Related issue: #2058

Revert #2051, fix #2058.

thomaswalker-dev · 2020-01-05T20:21:12Z

Any news on this?

Morinohtar · 2020-03-15T12:38:39Z

@yajra is this issue already addressed in the latest version or is it still going on?

carferdas · 2022-04-12T04:56:33Z

This fix not working

moeezs82 · 2022-11-22T11:22:53Z

public function query(Jobseeker $model): QueryBuilder
{
return $model->applyScopes($model->newQuery()->with([
'cv:id,jobseeker_id,name',
'jobseeker_ques_opt.options',
]))->latest();
}

//this is the parameter i'm passing for column search
->parameters([
'initComplete' => "function () {
this.api().columns().every(function () {
var column = this;
var input = document.createElement("input");
$(input).appendTo($(column.footer()).empty())
.on('keyup change', function(){
column.search($(this).val(), false, false, true).draw();
})
});
}"
])

this is my query for datatable it is working perfect but search is not working on relational data

Morinohtar added 2 commits April 10, 2019 15:54

Alias for joined table in BelongsTo

6c7f997

fix(QueryDataTableTest): replace deprecated function assertContains w…

db33565

…ith assertStringContainsString.

Morinohtar changed the title ~~Sorting nested relation that refer to the same table.~~ [9.0] Sorting nested relation that refer to the same table. Apr 10, 2019

Morinohtar changed the title ~~[9.0] Sorting nested relation that refer to the same table.~~ [9.0] Sorting nested relation that refers to the same table. Apr 10, 2019

yajra requested changes Apr 11, 2019

View reviewed changes

Morinohtar added 6 commits April 11, 2019 11:23

fix(EloquentDataTable): proper alias syntax according to database dri…

8ba66b3

…ver.

fix(EloquentDataTable): proper alias syntax according to database dri…

e7d6800

…ver.

Merge branch '9.0' of github.com:Morinohtar/laravel-datatables into 9.0

55a15fe

Merge branch '9.0' of github.com:Morinohtar/laravel-datatables into 9.0

2b637c4

Merge branch '9.0' of github.com:Morinohtar/laravel-datatables into 9.0

00cbfad

chore(EloquentDataTable): proper code style.

1fbe5eb

yajra reviewed Apr 15, 2019

View reviewed changes

yajra mentioned this pull request Apr 15, 2019

Search not working on relations field with same table. #2054

Closed

Morinohtar added 2 commits April 16, 2019 10:40

chore: reverting code.

5daf655

chore: reverting code.

b953eac

yajra merged commit f5e9438 into yajra:9.0 Apr 24, 2019

yajra changed the title ~~[9.0] Sorting nested relation that refers to the same table.~~ [9.0] Add support for self join relationships. Apr 24, 2019

yajra added a commit that referenced this pull request Apr 26, 2019

Revert #2051, fix #2058.

9bcb828

yajra mentioned this pull request Apr 26, 2019

Revert #2051, fix #2058. #2072

Merged

yajra added a commit that referenced this pull request Apr 26, 2019

Merge pull request #2072 from yajra/reverts

d725ca0

Revert #2051, fix #2058.

Morinohtar mentioned this pull request Apr 30, 2019

Eager Loading Filter and Search Issues #2058

Closed

yajra mentioned this pull request May 3, 2019

aliases losts in order by #2075

Closed

yajra mentioned this pull request May 22, 2019

Error when using NestableTrait #2059

Closed

yajra added the Self Join label Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0] Add support for self join relationships. #2051

[9.0] Add support for self join relationships. #2051

Morinohtar commented Apr 10, 2019

yajra left a comment

yajra Apr 11, 2019

Morinohtar Apr 11, 2019 •

edited

Loading

Morinohtar Apr 11, 2019

yajra Apr 12, 2019 •

edited

Loading

Morinohtar Apr 12, 2019

yajra Apr 15, 2019

Morinohtar Apr 15, 2019

yajra Apr 15, 2019

Morinohtar Apr 16, 2019

yajra commented Apr 24, 2019

amrmahrous commented Apr 25, 2019

yajra commented Apr 26, 2019

thomaswalker-dev commented Jan 5, 2020

Morinohtar commented Mar 15, 2020

carferdas commented Apr 12, 2022

moeezs82 commented Nov 22, 2022 •

edited

Loading

[9.0] Add support for self join relationships. #2051

[9.0] Add support for self join relationships. #2051

Conversation

Morinohtar commented Apr 10, 2019

yajra left a comment

Choose a reason for hiding this comment

yajra Apr 11, 2019

Choose a reason for hiding this comment

Morinohtar Apr 11, 2019 • edited Loading

Choose a reason for hiding this comment

Morinohtar Apr 11, 2019

Choose a reason for hiding this comment

yajra Apr 12, 2019 • edited Loading

Choose a reason for hiding this comment

Morinohtar Apr 12, 2019

Choose a reason for hiding this comment

yajra Apr 15, 2019

Choose a reason for hiding this comment

Morinohtar Apr 15, 2019

Choose a reason for hiding this comment

yajra Apr 15, 2019

Choose a reason for hiding this comment

Morinohtar Apr 16, 2019

Choose a reason for hiding this comment

yajra commented Apr 24, 2019

amrmahrous commented Apr 25, 2019

yajra commented Apr 26, 2019

thomaswalker-dev commented Jan 5, 2020

Morinohtar commented Mar 15, 2020

carferdas commented Apr 12, 2022

moeezs82 commented Nov 22, 2022 • edited Loading

Morinohtar Apr 11, 2019 •

edited

Loading

yajra Apr 12, 2019 •

edited

Loading

moeezs82 commented Nov 22, 2022 •

edited

Loading