Lwt return void #460
Merged
Lwt return void #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This retains the result field in the job struct and sets its type to int. Val_unit is now returned as the result rather than using the uninitialized result field.
|
Perhaps we can eliminate the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests that generating lwt job bindings to void-returning functions is broken in
masterand then fixes that defect during stub generation by usingintfor the type of the lwt jobresultfield (never initialized or used) and then returningVal_unitas the result.This isn't the prettiest solution but it does unblock me. Please let me know if you'd like to see a different approach used, I'd (probably) be happy to accommodate.