Dune port #574
Closed
Dune port #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
jbuilder-port
branch
2 times, most recently
from
37afedf
to
3797d8e
Compare
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg
force-pushed
the
jbuilder-port
branch
from
3797d8e
to
e2aea4e
Compare
Add _opam to .gitignore for opam 2
Travis : add an OCaml 4.07 job
Drop OCaml 4.01 support
use_value updates
Eliminate uses of <complex.h> on Android.
The usage of `I` provided by "complex.h" is error-prone, e.g `double complex z = Double_val(x) + I*(Double_val(y))` might give `NaN` as `creal(z)` for `x = 0.0` and `y = infinity`.
`__USE_MINGW_ANSI_STDIO` must be defined before any other relevant
headers are included. This is often not guaranteed because custom
headers are added before calls to `Cstubs.write_c`. A
macro ('ctypes_printf') is introduced instead.
Background: On windows one can link again various version of the
cstlib (crt). They are all not really compatible to C99. Instead of
testing workarounds for each version, the compatibility layer of mingw
is used.
workarounds for - ocaml/ocaml#1535 (no dll dependency) - ocaml/ocaml#1528 (string_of_float format) - ocaml/ocaml#1479 (chdir changes environment)
The result of `Data_custom_Val(caml_alloc_custom(...))` is word aligned. `long double` and `long double complex` are usually bigger. Such usage is even wrong on x86/amd64. Compilers are free to use e.g. the MOVDQA instruction, if you tell them that your pointers are properly aligned.
This was referenced Dec 29, 2018
avsm
added a commit
to avsm/dune
that referenced
this pull request
Dec 31, 2018
The current `C_define.Type.Int` supports signed integers since the fix in ocaml#1344. This fix meant that some C expressions cannot be evaluated such as `sizeof(expr)` since those are not valid in cpp. This changeset adds a new `Uint` type switch that is expressly for the purpose of evaluating unsigned C integers only. This allows for constructs such as `sizeof(expr)`. This changeset lets the Ctypes library completely use Configurator for all of its compile-time tests (yallop/ocaml-ctypes#574) fixes ocaml#1720 Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
until ocaml/dune#1724 is resolved Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
this lets an example build, but with an extra dependency since dune cannot track the `mt` predicates and hence doesnt know that the `date` example depends on ctypes-foreign-unthreaded see ocaml/dune#1724 for discussion
Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
|
Closing in favour of #588 where i've rebased and documented the progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up for @avsm