Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error caused by this package and supports auto linking #380

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix build error caused by this package and supports auto linking #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32018e9
Update build.gradle
maulikdhameliya Mar 16, 2020
cef5883
Merge pull request #1 from maulikdhameliya/v3.1.3-cf
maulikdhameliya Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
apply plugin: 'com.android.library'

def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

android {
compileSdkVersion 23
buildToolsVersion "23.0.1"
compileSdkVersion safeExtGet('compileSdkVersion', 28)

defaultConfig {
minSdkVersion 16
targetSdkVersion 22
minSdkVersion safeExtGet('minSdkVersion', 16)
targetSdkVersion safeExtGet('targetSdkVersion', 28)
versionCode 1
versionName "1.0"
ndk {
Expand Down
10 changes: 1 addition & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,5 @@
"bugs": {
"url": "https://github.com/yamill/react-native-orientation/issues"
},
"homepage": "https://github.com/yamill/react-native-orientation#readme",
"rnpm": {
"android": {
"packageInstance": "new OrientationPackage()"
},
"ios": {
"project": "iOS/RCTOrientation.xcodeproj"
}
}
"homepage": "https://github.com/yamill/react-native-orientation#readme"
}
10 changes: 10 additions & 0 deletions react-native.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
module.exports = {
rnpm: {
"android": {
"packageInstance": "new OrientationPackage()"
},
"ios": {
"project": "iOS/RCTOrientation.xcodeproj"
}
}
};