Support for full DN of the user in the member field when used with groupOfNames object class #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,6 +87,14 @@ private boolean filterByGroup(InitialDirContext context, String sanitizedUsernam | |||
| } | |||
| } | |||
|
|
|||
| private String userNameBaseOnGroupClass(String userName) { | |||
| if ("groupOfNames".equalsIgnoreCase(configuration.getGroupClassName()) | |||
| && "member".equalsIgnoreCase(configuration.getGroupMembershipAttribute())) { | |||
There was a problem hiding this comment.
"groupOfNames" and "member" seem pretty specific to your LDAP setup use case. Other setups can use other fields for their member identity :(
|
Maybe we can add in the ability to switch the fullDN based on a configuration parameter rather than magical group member fields? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that the current implementation seems to assume that groups are defined using posixGroup/memberUID, where memberUID is a short unique user ID. As I'm using groupOfNames for groups in LDAP I had to make it work with a member field which has to be defined as a full DN of the user. It's a small change, and others might find it useful too, so the pull request. Sorry for no unit tests, but your current structure didn't allow me to test it - that's my excuse :) However I've tested that change in my project in more end2end scenario and all my functional tests are green now.