Fix LIST_INSERT_HEAD on the empty list

Fixes #263
yamt · Sep 20, 2024 · 954598b · 954598b
1 parent e2de1e3
commit 954598b
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/list.c b/lib/list.c
@@ -77,17 +77,16 @@ list_insert_head(struct list_head *h, void *elem, struct list_entry *e)
 {
         list_check2(h, elem, e, false);
         if (h->first == NULL) {
-                e->next = NULL;
                 h->tailnextp = &e->next;
         } else {
                 uintptr_t offset = (uintptr_t)e - (uintptr_t)elem;
                 struct list_entry *firstentry =
                         (void *)((uintptr_t)h->first + offset);
                 assert(firstentry->prevnextp == &h->first);
                 firstentry->prevnextp = &e->next;
-                e->next = h->first;
-                e->prevnextp = &h->first;
         }
+        e->next = h->first;
+        e->prevnextp = &h->first;
         h->first = elem;
         assert(h->first != NULL);
         assert(*e->prevnextp == elem);