wasi: raise a trap on out-of-range memory access #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamt
commented
Jan 14, 2023
lib/wasi.c
Outdated
| int ret = 0; /* never fail */ | ||
| HOST_FUNC_RESULT_SET(ft, results, 0, i32, | ||
| wasi_convert_errno(ret)); | ||
| } | ||
| return 0; |
lib/wasi.c
Outdated
| if (host_ret == 0) { | ||
| HOST_FUNC_RESULT_SET(ft, results, 0, i32, | ||
| wasi_convert_errno(ret)); | ||
| } | ||
| return 0; |
lib/wasi.c
Outdated
| if (host_ret == 0) { | ||
| HOST_FUNC_RESULT_SET(ft, results, 0, i32, | ||
| wasi_convert_errno(ret)); | ||
| } | ||
| return 0; |
| pathlen1, &wasmpath1, &hostpath1); | ||
| if (ret != 0) { | ||
| int host_ret; | ||
| int ret = 0; |
There was a problem hiding this comment.
unnecessary initialization as wasi_copyin_and_convert_path always set ret.
The previous logic was broken. It was returning EFAULT (which indicating a trap in memory_getptr) to the caller without processing the trap properly. This commit fixes it by distinguishing user-level error and host-level error. EFAULT for traps is a host-level error. cf. WebAssembly/WASI#505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic was broken.
It was returning EFAULT (which indicating a trap in memory_getptr) to the caller without processing the trap properly.
This commit fixes it by distinguishing user-level error and host-level error. EFAULT for traps is a host-level error.
cf. WebAssembly/WASI#505