Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs #2

Closed
13 tasks done
yan12125 opened this issue Apr 8, 2019 · 1 comment
Closed
13 tasks done

TODOs #2

yan12125 opened this issue Apr 8, 2019 · 1 comment

Comments

@yan12125
Copy link
Owner

yan12125 commented Apr 8, 2019

yan12125 pushed a commit that referenced this issue May 21, 2022
yan12125 pushed a commit that referenced this issue Jun 20, 2022
* Fix test_stay_connected when stdin is not a tty

That happens on GitHub Actions runners. When stdin is a tty,
LogcatColor.start() runs logcat first, so there is one more adb command
compared to the case when stdin is not a tty. Use an input file for test
consistency on varying environments.

See: #2
yan12125 added a commit that referenced this issue May 4, 2023
TODO: check if those changes are correct

Ref: #2
yan12125 added a commit that referenced this issue May 19, 2023
yan12125 added a commit that referenced this issue Jun 1, 2023
yan12125 added a commit that referenced this issue Jun 2, 2023
@yan12125
Copy link
Owner Author

yan12125 commented Jun 2, 2023

All tasks are done :)

@yan12125 yan12125 closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant