-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Q&A (pre v1.0.0) #1
Comments
Thank you for putting this together; I was just mucking around with updating the My only complaint is that the stylization of Other than that, I consider this to be a really handy addition to my workflow; thank you! EDIT: I don't suppose there's any way to get HTTPS, is there? EDIT2: Not get greedy, but perhaps also an optional config argument for specifying whether the automatically opened page uses the |
You're welcome :)
I have changed it in a812af8.
There is. And I have just improved it in 5b08a7b. You can now set the option
This is already included. I have now set the default A detailed documentation will follow soon. |
@zalo I have published the latest version with all your feature requests. In the next version, I will add a logging system to be able to view your phones There will also be a Chrome Extension for connecting SSR content with Five Server. |
Awesome! Thank you very much for this! These are all handy quality of life improvements that I'm sure will benefit more than just me :-)
This is huge! I'd recently taken to appending worker and page errors as divs to view them on mobile, but doing it through the Live Server's websockets connection would be a dramatic improvement on that workflow!
I don't personally do a ton of server-side stuff, but I'm sure it will be useful. A way to call commands on each file save (like Thanks again! |
Quick Request: If the page isn't being viewed on mobile, could you avoid intercepting the |
Yes, set
Could you elaborate what you mean? |
Hey, so i have a tiny issue... Its not opening in browser What I've done: It starts the port, but doesn't actually open the HTML file in my browser..? |
Hi @iamk3v , Thanks for reporting.
|
Ive tried restarting VSC and removing Live Server (keeping only Five Server) Without any success. As i mentioned, I've only installed the extension (no node.js installation or anything), and i do not use a Five Server config file. OS and Browser: When i click on the go live on the bottom right in my vsc it opens the root folder that i have opened (where i can navigate to my HTML file). From there it looks to be working fine, but i would love for it to actually open directly without me having to navigate.. As of now its doing nothing except start the port when i right click and select Open Five Server |
Good to hear. At least this is working 👍 I think some paths are mixing up. // fiveserver.config.js
module.exports = {
debugVSCode: true,
}; |
Also try: // fiveserver.config.js
module.exports = {
debugVSCode: true,
browser: ["google chrome", "google-chrome", "google-chrome-stable", "chrome"],
}; |
i added the file "fiveserver.config.js" in my root folder (as you can see on the screenshot), but nothing is popping up in terminal when i switch to the five server terminal? The file I'm trying to run is the one highlighted in red: Do you have Discord or anything where i could contact you? I'm genuinely confused why nothing is working EDIT: |
|
Moved over to discussions :) |
Thanks for reporting! Can you try to use Watch & Ignore? |
Adding a file with However, I also notice that the original live server doesn't exhibit this behavior (even without a config) on the same project. |
Fixed |
I just released v0.0.25 (vscode) and I'm pretty happy with it. The next goal is to improve the Instant Update and Highlight feature :) |
Thanks for taking this up. One code issue... I'm all in on ES Modules and you have to specify import LiveServer from 'five-server';
const liveServer = new LiveServer.default(); A general branding suggestion; take or leave it. It seems to make sense to publish |
I see. Yes, I will try to figure out the right settings. I admit I have never used Node.js ES Modules before. I almost always write in TypeScript.
You're right! Maybe I should. But not @fiveserver/core
@fiveserver/hot-reload
@fiveserver/html-validtor
@fiveserver/etc. But I guess I wait until the project gets bigger. For now, I don't need to split the code into multiple packages. Also, I hmm, I actually don't really see the benefit of splitting Node.js modules since bundle size does not really matter. five-server # includes everything (core, hot-reload, html-validator)
five-server-my-plugin # some plugin, someone publishes Really, I'm not sure what I would prefer 🤔 btw, thanks for being a sponsor 😃 |
Right on. re: hot body injection. At some point a WebStorm plugin would be awesome too. My comment on the naming of I do see a point in having a unique name in regards to 3rd party plugins though. |
Thank you so much for this extension, I've been looking for preview with highlights since announced end of support for brackets. |
You're welcome 😊
Should already work if you use an extension like Browser Preview. |
Does someone need instant updates for PHP files? |
That PHP Preview feature is really cool! I'm sure PHP developers will get some good use out of it. On a side note, I've recently learned that VS Code has the ability to automatically hook into the Chrome Debugger by setting: This seems like too cool of a feature to leave locked behind obscurity: would it make sense to have FiveServer automatically open the website in Debugger mode when Go Live is clicked? These lines within the default VS Code debugging extension might be useful... |
I don't know much about the VS Code debugging features. Is it necessary to build something into Five Server? How would users benefit from it?
I think it would just confuse most users. |
@typhonrt I just can't figure out the right settings. Does anyone know? |
@yandeu I'm a FED, as, I suspect, a great many of the people using this sort of instant, just-add-WWWater webserver extension are. Lack of the ability to compile and serve style code (and again, this is shelving entirely the file/folder monitoring/direct injection capabilities) is a deal-breaker, for me at least. I may as well just run the code with a |
I did not know that. There is already another fork. Have you tried it?
I don't understand what you mean in the second paragraph :/ |
I just switched from live-server. to five server in my VSCode. Here's my setting.
|
@norixx Thanks for reporting Please <script async data-id="five-server" src="http://localhost:5500/fiveserver.js"></script> To make this work, you also have to enable cors for the five server: module.exports = {
cors: true
} UpdateI have detected 3 issues: The proxy-middleware:
This should all work in the next version. |
In docs, caching with prepend <img src="/.cache/https://external.image/cat.jpg"> What about caching assets with cache attribute like this: <img src="https://external.image/cat.jpg" cache> |
I use Sublime. But, I want this feature 🥺 |
|
where is that file when using fiveserver in vscode? please
|
Root of your workspace. |
Thank you , I just saw that there is a dedicated input field in teh vscode settings :) |
Hi, I found a bug: "CSS updated" status doesn't go away after updating CSS The status won't go away and creates a large stripe spanning from the top to the center of the page. I'm using version 0.0.32 of five server and version 1.59 of visual studio code |
Using Fiveserver in VSCode. |
Try #23 (comment) |
Everything works pretty well. I will close this issue and soon release v0.1.0 :) |
Want to ask questions? Here is the right place.
The text was updated successfully, but these errors were encountered: