Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logicng to 2.5.0 #147

Merged
merged 2 commits into from
May 2, 2024
Merged

Update logicng to 2.5.0 #147

merged 2 commits into from
May 2, 2024

Conversation

Jeffset
Copy link
Contributor

@Jeffset Jeffset commented May 2, 2024

Fix: Update logicng to 2.5.0.

new version is lighter and does not depend on the ANTLR library which may cause conflicts at runtime.

Closes #145

CI: Replace gradle-build-action.

gradle-build-action is replaced with gradle/actions/setup-gradle, as per it migration guide. The former is deprecated.

`gradle-build-action` is replaced with `gradle/actions/setup-gradle`,
as per it migration guide.
The former is deprecated.
The new version is lighter and does not depend on
 the ANTLR library which may cause conflicts at runtime.
@Jeffset Jeffset requested a review from bacecek May 2, 2024 17:31
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (49c19ac) to head (5e0bc15).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #147   +/-   ##
=========================================
  Coverage     83.90%   83.90%           
  Complexity     1577     1577           
=========================================
  Files           191      191           
  Lines          7686     7686           
  Branches       1428     1428           
=========================================
  Hits           6449     6449           
  Misses          732      732           
  Partials        505      505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffset Jeffset marked this pull request as ready for review May 2, 2024 17:38
@Jeffset Jeffset merged commit f07a196 into main May 2, 2024
4 checks passed
@Jeffset Jeffset deleted the wp/fix-145 branch May 2, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on ANTLR
2 participants