Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of technical stuff #157

Merged
merged 3 commits into from
May 24, 2024
Merged

A bunch of technical stuff #157

merged 3 commits into from
May 24, 2024

Conversation

Jeffset
Copy link
Contributor

@Jeffset Jeffset commented May 23, 2024

Refactor: do not do @file:OptIn

IDE sometimes stops recognizing it and highlights the usages as errors.
So annoying! And anyway, better to opt-in more locally.


Refactor, Infra: Improve ClasspathSourceGeneratorTask.

Make a single task generate all the required properties.
Support grouping the properties into the objects.


Versions: Migrate kover to 0.8.0.

Fedor Ihnatkevich added 2 commits May 22, 2024 17:44
IDE sometimes stops recognizing it and highlights the usages as errors.
So annoying! And anyway, better to opt-in more locally.
Make a single task generate all the required properties.
Support grouping the properties into the objects.
@Jeffset Jeffset added the technical Related to internal project organisation, infrastructure, CI, etc. label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (32e3a43) to head (8c5b787).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #157   +/-   ##
=========================================
  Coverage     83.86%   83.86%           
  Complexity     1598     1598           
=========================================
  Files           197      197           
  Lines          7681     7681           
  Branches       1448     1448           
=========================================
  Hits           6442     6442           
  Misses          729      729           
  Partials        510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffset Jeffset requested a review from bacecek May 23, 2024 10:14
@Jeffset Jeffset marked this pull request as ready for review May 23, 2024 10:30
@Jeffset Jeffset merged commit 4b82b9d into main May 24, 2024
4 checks passed
@Jeffset Jeffset deleted the wp/refactors branch May 24, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Related to internal project organisation, infrastructure, CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants