Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api: Support dagger compat mode for RT. #158

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Api: Support dagger compat mode for RT. #158

merged 1 commit into from
Jun 10, 2024

Conversation

Jeffset
Copy link
Contributor

@Jeffset Jeffset commented May 24, 2024

Check flag and runtime dagger api presence to enable appropriate logic.

Check flag and runtime dagger api presence
 to enable appropriate logic.
@Jeffset Jeffset added the api Related to introducing new API or changing existing one label May 24, 2024
@Jeffset Jeffset added this to the 2.0.0 milestone May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 83.72%. Comparing base (8c5b787) to head (5037e40).
Report is 1 commits behind head on main.

Files Patch % Lines
...otlin/com/yandex/yatagan/lang/rt/RtDaggerCompat.kt 74.64% 12 Missing and 6 partials ⚠️
...yandex/yatagan/rt/engine/compatAccessStrategies.kt 70.00% 6 Missing ⚠️
...lin/com/yandex/yatagan/dynamic/ReflectionLoader.kt 0.00% 1 Missing and 2 partials ⚠️
...otlin/com/yandex/yatagan/lang/rt/RtLexicalScope.kt 71.42% 1 Missing and 1 partial ⚠️
.../kotlin/com/yandex/yatagan/lang/rt/RtMethodImpl.kt 86.66% 0 Missing and 2 partials ⚠️
...om/yandex/yatagan/lang/rt/RtTypeDeclarationImpl.kt 75.00% 0 Missing and 2 partials ⚠️
...lin/com/yandex/yatagan/core/model/impl/coreUtil.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #158      +/-   ##
============================================
- Coverage     83.86%   83.72%   -0.15%     
- Complexity     1598     1621      +23     
============================================
  Files           197      199       +2     
  Lines          7681     7803     +122     
  Branches       1448     1474      +26     
============================================
+ Hits           6442     6533      +91     
- Misses          729      745      +16     
- Partials        510      525      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffset Jeffset marked this pull request as ready for review May 24, 2024 07:01
@Jeffset Jeffset requested a review from byar June 4, 2024 19:27
@Jeffset Jeffset merged commit 25bb3e0 into main Jun 10, 2024
4 checks passed
@Jeffset Jeffset deleted the wp/rt-compat branch June 10, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to introducing new API or changing existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants