Api: Rework YataganReflection to improve usability.
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a preparation for #31 |
|
Another change here is, that |
byar
approved these changes
Apr 19, 2023
Jeffset
force-pushed
the
reflection-api-rework2
branch
from
e7f2f7f
to
959f498
Compare
`YataganReflection` runtime API is replaced with properties file in java resources to simplify reflection setup by hand (no complicated source directories setup is strictly necessary). All required parameters, including validation delegate class name is read from `META-INF/com.yandex.yatagan.reflection/parameters.properties`. Such file can be automatically generated by a gradle plugin based on DSL setup. Also, this CL removes "validation-less" mode for reflection, as it has questionable applicability to any real environment, so there's no point in supporting such a mode. Now reflection's validation defaults to `SimpleDynamicValidationDelegate`, which has reasonable defaults to synchronously check graphs upon creation.
Jeffset
force-pushed
the
reflection-api-rework2
branch
from
959f498
to
61a1fc3
Compare
byar
approved these changes
Apr 19, 2023
ArturVasilov
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YataganReflectionruntime API is replaced with propertiesfile in java resources to simplify reflection setup by hand
(no complicated source directories setup is strictly necessary).
All required parameters, including validation delegate class name
is read from
META-INF/com.yandex.yatagan.reflection/parameters.properties.Such file can be automatically generated by a gradle plugin
based on DSL setup.
Also, this CL removes "validation-less" mode for reflection,
as it has questionable applicability to any real environment,
so there's no point in supporting such a mode.
Now reflection's validation defaults to
SimpleDynamicValidationDelegate, which has reasonable defaultsto synchronously check graphs upon creation.