Kapt: Properly fix annotation ordering issue. #75
Conversation
As per KT-51087, kapt generated annotations in reverse order, which was important for Yatagan. This CL adds logic to reverse annotations based on kotlin metadata version check. The ultimate reason for the fix was that `room-compiler-processing-testing` in `2.6.0-beta01` migrated to 1.9.x Kotlin compiler and some tests were broken. Closes #74
| @@ -170,6 +170,7 @@ abstract class CompileTestDriverBase private constructor( | |||
| "-opt-in=com.yandex.yatagan.ConditionsApi", | |||
| "-opt-in=com.yandex.yatagan.VariantApi", | |||
| "-P", "plugin:org.jetbrains.kotlin.kapt3:correctErrorTypes=true", | |||
| "-jvm-target=11", | |||
There was a problem hiding this comment.
Btw, why tests are running on Java 11, but target is 8?
There was a problem hiding this comment.
Testing framework requires 11+, but yatagan itself is built with 8 to maximize compatibility, as far as I remember.
| @@ -21,14 +21,16 @@ import com.yandex.yatagan.lang.compiled.CtAnnotationBase | |||
| import javax.lang.model.element.AnnotationMirror | |||
| import javax.lang.model.element.Element | |||
|
|
|||
| // See https://youtrack.jetbrains.com/issue/KT-51087, which was fixed in [1, 9, 0] metadata version. | |||
There was a problem hiding this comment.
Target version in KT-51087 is 1.8.20-Beta. Is this version already have 1.9.0 metadata version?
There was a problem hiding this comment.
Well, It seemed to me, but I better double check
There was a problem hiding this comment.
Turns out, metadata version in the code, generated by 1.8.20 compiler, is still [1, 8, 0], so such check is not sound.
Moreover, if the kotlin.Metadata is present, it doesn't mean the code is from KAPT (a stub), it may well be an already compiled bytecode, which always had correct annotation order. And there's no way to determine whether the element is backed by source or bytecode.
So, the task to make a sound decision here seems impossible :(
As per KT-51087, kapt generated annotations in
reverse order, which was important for Yatagan.
This CL adds logic to reverse annotations based
on kotlin metadata version check.
The ultimate reason for the fix was that
room-compiler-processing-testingin2.6.0-beta01migrated to 1.9.x Kotlin compiler and some tests were broken.Closes #74