Skip to content
This repository has been archived by the owner on Dec 26, 2018. It is now read-only.

Tick stroke and tick text stroke properties in charts #38

Closed
wants to merge 3 commits into from

Conversation

arisgk
Copy link
Contributor

@arisgk arisgk commented Jun 12, 2016

I could not change the tick stroke and tick text stroke using properties. Adding them as props in chart components did the trick. I added tickTextStroke into axis components propTypes too. It is my very first open source contribution so tell me if I did anything wrong in the process.

@yang-wei
Copy link
Owner

oh @arisgk thanks for this but instead of adding each propTypes to each chart, I prefer you to add them to CartesianChartPropsMixin.js

You can take a look how this is done in another pr - #27

And also welcome to OSS

@arisgk
Copy link
Contributor Author

arisgk commented Jun 16, 2016

Okay, @yang-wei do you think it is better to go for separate xAxisTickStroke and yAxisTickStroke or a common tickStroke prop for both axes?

@yang-wei
Copy link
Owner

separate will be fine since this is how our API looks like

@arisgk
Copy link
Contributor Author

arisgk commented Jul 3, 2016

@yang-wei I added xAxisTickStroke, xAxisTickTextStroke, yAxisTickStroke, yAxisTickTextStroke to CartesianChartPropsMixin.js.

yang-wei added a commit that referenced this pull request Jul 24, 2016
@yang-wei
Copy link
Owner

will merge in #70

@yang-wei yang-wei closed this Jul 24, 2016
@arisgk arisgk deleted the tick-color branch July 26, 2016 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants