This repository has been archived by the owner on Dec 26, 2018. It is now read-only.
Added wrapping for axis tick labels #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed my code offsets Y-axis text by a bit |
|
Fixed Y-axis alignment |
|
Can you give me a visual presentation of what does this code can solve =) |
|
So basically it solves this issue |
yang-wei
reviewed
Oct 8, 2016
| @@ -221,7 +221,11 @@ module.exports = React.createClass({ | |||
| textAnchor={textAnchor} | |||
| {...optionalTextProps} | |||
| > | |||
| {tickFormat(tick)} | |||
| {`${tickFormat(tick)}`.split('\n').map((tickLabel) => ( | |||
There was a problem hiding this comment.
{tickFormat(tick)} should be enough instead wrapping it with template string ?
There was a problem hiding this comment.
Thats what i did earlier but some tests failed with that so was forced into using template string
PhantomJS 2.1.1 (Mac OS X 0.0.0) BarChart renders barchart FAILED
undefined is not a constructor (evaluating 'tickFormat(tick).split('\n')')
and 2 other failures
There was a problem hiding this comment.
I see... tickFormat(tick) is not recognised as string
|
Here's a visual of what it fixes, Observe the X axis Before Fix: After Fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, long labels aren't wrapped on the axes. I updated the render code to support for newline characters. Ideally this should be automatic wrapping on long labels but this was good enough for my purposes and i'll try and add automatic wrapping later.