Fix possible segment fault in delete_stats() of MultiDimension. (apac…

…he#2237) (apache#2238) Signed-off-by: Ketor <d.ketor@gmail.com>
yanglimingcn · Oct 31, 2023 · 2ebf984 · 2ebf984
1 parent a41c7c3
commit 2ebf984
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/bvar/multi_dimension_inl.h b/src/bvar/multi_dimension_inl.h
@@ -118,6 +118,7 @@ void MultiDimension<T>::delete_stats() {
     // then traversal tmp_map and delete bvar object,
     // which can prevent the bvar object from being deleted twice.
     MetricMap tmp_map;
+    CHECK_EQ(0, tmp_map.init(8192, 80));
     auto clear_fn = [&tmp_map](MetricMap& map) {
         if (!tmp_map.empty()) {
             tmp_map.clear();

diff --git a/test/bvar_multi_dimension_unittest.cpp b/test/bvar_multi_dimension_unittest.cpp
@@ -355,6 +355,8 @@ TEST_F(MultiDimensionTest, stats) {
     ASSERT_FALSE(my_madder.has_stats(labels_value2));
     ASSERT_FALSE(my_madder.has_stats(labels_value3));
     ASSERT_FALSE(my_madder.has_stats(labels_value4));
+    bvar::Adder<int> *adder5 = my_madder.get_stats(labels_value1);
+    ASSERT_TRUE(adder5);
 }
 
 TEST_F(MultiDimensionTest, get_description) {