Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic conventions #66

Merged
merged 3 commits into from
Feb 11, 2023

Conversation

plantfansam
Copy link
Contributor

@plantfansam plantfansam commented Feb 7, 2023

Per open-telemetry/community#1276 (comment), this PR adds semantic conventions so the library can be more spec-compliant. Users can use these modules to generate spec-compliant telemetry, e.g.:

local c = require("opentelemetry/semantic_conventions/trace/cloudevents")
tracer:start(context, name, {kind = span_kind.server, attributes = {attr.string(`c.CLOUDEVENTS_EVENT_ID`, "foo")}}

Addresses #65

@yangxikun yangxikun merged commit 83f835a into yangxikun:main Feb 11, 2023
@plantfansam plantfansam deleted the add-semantic-conventions branch February 13, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants