Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip change value.yank #1

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Skip change value.yank #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions api/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ func (c *Config) Validate() error {
}
case Kind_LOCAL:
}
if c.GetTarget().GetContainerRegistry() == "" {
return errors.Errorf(`"target.containerRegistry" cannot be empty`)
}
if c.GetTarget().GetContainerRepository() == "" {
return errors.Errorf(`"target.containerRepository" cannot be empty`)
}
// if c.GetTarget().GetContainerRegistry() == "" {
// return errors.Errorf(`"target.containerRegistry" cannot be empty`)
// }
// if c.GetTarget().GetContainerRepository() == "" {
// return errors.Errorf(`"target.containerRepository" cannot be empty`)
// }
}

// Authentication
Expand Down
5 changes: 5 additions & 0 deletions internal/chart/sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ import (
// repo to the target repo
func ChangeReferences(chartPath, name, version string, source *api.Source, target *api.Target) error {
// Update values*.yaml
if target.GetContainerRegistry() == "" && target.GetContainerRepository() == "" {
// Skip modify value.yaml and readme
return nil
}

for _, f := range []string{
path.Join(chartPath, ValuesFilename),
path.Join(chartPath, ValuesProductionFilename),
Expand Down