Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error from masked dplyr::count #7

Closed
LKBlum opened this issue May 12, 2020 · 4 comments
Closed

error from masked dplyr::count #7

LKBlum opened this issue May 12, 2020 · 4 comments

Comments

@LKBlum
Copy link

LKBlum commented May 12, 2020

Thanks for making this package.

I was getting the following error for any input, including the example data:

Error in count(., A, B, C, D) : Argument 'x' must be a vector: list

The issue was from another loaded package (DESeq2) that masked dplyr::count. It works if I copy the ggvenn code and replace "count" with "dplyr::count" or if I detach DESeq2 before calling ggvenn.

Not sure that's worth an update, but someone may find this if they run into the same issue.

@QqQss
Copy link

QqQss commented May 18, 2020

same issue.
how can I fix it? I cannot find 'count' function in the raw code.

@QqQss
Copy link

QqQss commented May 18, 2020

OK. this issue will be gone by
just run
count = dplyr::count
before ggvenn

@DarwinAwardWinner
Copy link

This is an issue with the package itself. The NAMESPACE file doesn't import the dplyr functions that it uses, which allows them to be masked. The package should be explicitly declaring all its imports as described here: http://r-pkgs.had.co.nz/namespace.html#namespace-NAMESPACE

@yanlinlin82
Copy link
Owner

Thank you guys for your interest in this package and the nice suggestions. I just added the import declaration. Hope this works. @LKBlum @QqQss @DarwinAwardWinner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants