Add support for Arm64 Docker images #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannh
added a commit
that referenced
this pull request
May 14, 2023
chenrui333
reviewed
May 14, 2023
| - 'ghcr.io/{{.Env.GIT_OWNER}}/kubeconform:{{ .Tag }}-arm64-alpine' | ||
| dockerfile: Dockerfile-alpine | ||
| build_flag_templates: | ||
| - "--platform=darwin/arm64" |
There was a problem hiding this comment.
there is no darwin platform support for alpine image, this PR should do the job
chenrui333
reviewed
May 14, 2023
| @@ -1,4 +1,4 @@ | |||
| FROM alpine:3.14 as certs | |||
| FROM alpine:3.14 | |||
There was a problem hiding this comment.
3.14 has been deprecated for quite some time, 3.18 is the latest and greatest
There was a problem hiding this comment.
I create a PR for updating the alpine base image dependency as well, #203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instruct goreleaser to also build arm64 images.