Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: fix require_app_auth matches unexpected routes #42

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Bug: fix require_app_auth matches unexpected routes #42

merged 2 commits into from
Sep 19, 2023

Commits on Aug 31, 2023

  1. Update _url.py to not match for repositories starting with app 

    `APP_ROUTES` contains an `r"/app"` entry to match for the `/app` route. This will also match repositories which start with `app` causing `require_app_auth` to return true.

This change adjusts the `/app` regex to match at the beginning of the string and not anywhere within the url.path
    @udangel-r7
    udangel-r7 authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    c437493 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. 🐛 fix app auth regex

    @yanyongyu
    yanyongyu committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    557ef70 View commit details
    Browse the repository at this point in the history