Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash issue #221,#250; #251

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix crash issue #221,#250; #251

wants to merge 1 commit into from

Conversation

lixiangthinker
Copy link 

mCheckedList could be accessed in 2 threads, AlbumActivity and GalleryActivity(onPreviewChanged). AlbumActivity calls complete() and start new thread to generate thumbnail, while galleryactivity uncheck some file and change mCheckedList, then will crash.
This change will not allow changing mCheckedList while thumbnail task is running.

Fix crash issue #221,#250;
34db2f8 
    mCheckedList could be accessed in 2 threads, AlbumActivity and GalleryActivity(onPreviewChanged). AlbumActivity calls complete() and start new thread to generate thumbnail, while galleryactivity uncheck some file and change mCheckedList, then will crash.
    This change will not allow changing mCheckedList while thumbnail task is running.
@lixiangthinker lixiangthinker changed the base branch from master to dev February 1, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lixiangthinker