Add Node 20

[segevfiner]

It's now the latest LTS.

[robertsLando]

Unfortunately we don't have anyone right now able to create the v20 patches

[glektarssza]

Would be addressed by #11

[robertsLando]

Fixed in #11

[viceice]

i think this should be re-opened until the build issues are fix.

[robertsLando]

I tried a fix in #12 see https://github.com/yao-pkg/pkg-fetch/actions/runs/7087432653/job/19287673723

[robertsLando]

Seems the build is going some steps further this time: https://github.com/yao-pkg/pkg-fetch/actions/runs/7087579394/job/19288161530 🎉

[viceice]

nice, it seems you should update some actions which will otherwise fail in near future

Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

it's the docker build and push action.

[glektarssza]

nice, it seems you should update some actions which will otherwise fail in near future

Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

it's the docker build and push action.

@viceice I can open a separate ticket and take a look at this in the next few days if you want.

[viceice]

nice, it seems you should update some actions which will otherwise fail in near future

Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

it's the docker build and push action.

@viceice I can open a separate ticket and take a look at this in the next few days if you want.

I would suggest to use renovate for automated updates (I'm a maintainer 😉)

[glektarssza]

nice, it seems you should update some actions which will otherwise fail in near future

Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

it's the docker build and push action.

@viceice I can open a separate ticket and take a look at this in the next few days if you want.

I would suggest to use renovate for automated updates (I'm a maintainer 😉)

@viceice Sure, I can look at it! I'll open an issue to track.

[robertsLando]

Seems some matrix was missing :( need to trigger another build

28d96e9

Closing this

[robertsLando]

will remove nodejs19 on next release, just because we need to be sure v20 works propely before dropping it. Every feedback is welcome!

[viceice]

Will try v20 at https://github.com/containerbase/base now

[viceice]

@robertsLando Can you publish a new release of @yao-pkg/pkg-fetch and @yao-pkg/pkg to include the v20?

Error [ReportedError]: No available node version satisfies 'v20'

🙃

[robertsLando]

@viceice Actually I'm waiting for this to end: https://github.com/yao-pkg/pkg-fetch/actions/runs/7097555049

linux-arm64 and macos arm64 binaries were missing.

Anyway I suggest you to clone both packages locally and use npm link

[viceice]

@viceice Actually I'm waiting for this to end: https://github.com/yao-pkg/pkg-fetch/actions/runs/7097555049

linux-arm64 and macos arm64 binaries were missing.

All done 🙃

Anyway I suggest you to clone both packages locally and use npm link

Will try, but not enough time for that yet 😉

[robertsLando]

pkg 5.11.0 is out now

https://github.com/yao-pkg/pkg/releases/tag/v5.11.0

[viceice]

will try tomorrow

[glektarssza]

Seems some matrix was missing :( need to trigger another build

28d96e9

Closing this

How on earth did I miss that... :<

Oh well, glad you caught it.

[robertsLando]

No worries @glektarssza you already did a lot with that patch 🙏🏻

[viceice]

Seems to work for amd64 and arm64 🎉

• feat(cli): update node to v20 containerbase/base#1834

[robertsLando]

Niceee 🚀

[robertsLando]

Just created a workflow that automatically bumps patches (at least when them apply cleanly) 🚀