feat: support for latest NodeJS v20

[glektarssza]

Seems to be working!

[robertsLando]

@glektarssza thanks so much for your PR, I can give it a review tomorrow 🙏🏻 did you tried to run all the tests locally? Also did you tried to spawn a binary build on your fork? If not give it a try to see if the build ends correctly 🙌🏻

[glektarssza]

@glektarssza thanks so much for your PR, I can give it a review tomorrow 🙏🏻 did you tried to run all the tests locally? Also did you tried to spawn a binary build on your fork? If not give it a try to see if the build ends correctly 🙌🏻

@robertsLando Morning! No rush, I understand it's the weekend and it's an open-source project. I ran the verify script and it did pass. If there are more tests I should run please point me to them and I'd be happy to run them. I'll try to build a binary off my glektarssza/ftb-tool project later today and report back how it works.

[glektarssza]

Building using my prebuilt binary.

Build works in the wild, at least on my WSL Debian instance.

[robertsLando]

Can't say much about the patch as I'm not a NodeJS core/C++ expert but for the rest it looks good to me

Thanks so much for your contribution @glektarssza, this is a long awaited feature 🙏🏼

[robertsLando]

Crossed fingers 🤞🏼 https://github.com/yao-pkg/pkg-fetch/actions/runs/7083731774

[robertsLando]

Failed on alpine and linuxstatic ARM64:

https://github.com/yao-pkg/pkg-fetch/actions/runs/7083731774/job/19276653688
https://github.com/yao-pkg/pkg-fetch/actions/runs/7083731774/job/19276658686

Error seems related to an unrecognized option on g++:

g++: error: unrecognized command-line option '-msign-return-address=all'

https://github.com/yao-pkg/pkg-fetch/actions/runs/7083731774/job/19276653688#step:4:30520

And that seems a known error: nodejs/node#45756

Maybe that should be added to patch? Seems to only happen when cross-building arm64

UPDATE

Also windows x64 has failed: https://github.com/yao-pkg/pkg-fetch/actions/runs/7083731774/job/19276659687#step:6:31323

What I suggest is to try running those actions on your fork when doing tests

[ptaferner]

UPDATE

Also windows x64 has failed: https://github.com/yao-pkg/pkg-fetch/actions/runs/7083731774/job/19276659687#step:6:31323

What I suggest is to try running those actions on your fork when doing tests

This is a trivial syntax error: Just need to remove the double "return" on line 93 of node_main.cc.
I just did that and got a successful build on win64.

Btw, I will use the binary for an internal application at my company, so I can give some feedback if I see any issues with the patched node binary.

[robertsLando]

Yeah just submitted a fix for the patch, need to sort out how to fix the arm64 problem now...

[robertsLando]

Seems the ARM64 error was fixed in vercel#280 by @baparham. Seems it has been ported to v20 patch too so I don't understand why it's failing.

@baparham any clue?

[ptaferner]

My application currently fails with:

node:internal/bootstrap/realm:422
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'internal/modules/cjs/helpers'
    at requireBuiltin (node:internal/bootstrap/realm:422:19)
    at pkg/prelude/bootstrap.js:1883:10
    at pkg/prelude/bootstrap.js:1982:3
    at pkg/prelude/bootstrap.js:2255:3
    at readPrelude (node:internal/bootstrap/pkg:36:12)
    at node:internal/bootstrap/pkg:41:18
    at node:internal/bootstrap/pkg:48:4
    at node:internal/bootstrap/pkg:49:2

Node.js v20.10.0

This is probably unrelated to pkg-fetch and rather an issue with pkg. I'm analyzing that now.

[robertsLando]

@ptaferner Are you using pkg master branch? Dunno if it could be someway related to yao-pkg/pkg#8

[robertsLando]

I may have a fix for arm64 too: https://github.com/yao-pkg/pkg-fetch/actions/runs/7087579394/job/19288161530, for some reason the patch could not be needed anymore with node20

[ptaferner]

@ptaferner Are you using pkg master branch? Dunno if it could be someway related to yao-pkg/pkg#8

Ah, many thanks! This has indeed resolved the problem and my app runs now! :)

[robertsLando]

@ptaferner Did you reverted that change and it worked so? Strange...