Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Node 22 patch (#45) (by @faulpeltz) #45

Merged
merged 1 commit into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-alpine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ on:

jobs:
alpine:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04

strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 20]
target-node: [16, 18, 20, 22]
target-arch: [x64, arm64]
include:
- target-arch: x64
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 20]
target-node: [16, 18, 20, 22]

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -43,12 +43,12 @@ jobs:
path: dist/*

linux-arm64:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04

strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 20]
target-node: [16, 18, 20, 22]

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-linuxstatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ on:

jobs:
linuxstatic:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04

strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 20]
target-node: [16, 18, 20, 22]
target-arch: [x64, arm64, armv7]
include:
- target-arch: x64
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 20]
target-node: [16, 18, 20, 22]

steps:
- uses: actions/checkout@v4
Expand All @@ -20,10 +20,10 @@ jobs:
with:
xcode-version: latest

- name: Use Node.js 18
- name: Use Node.js 20
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: Check arch is x64
run: |
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 20]
target-node: [16, 18, 20] # disabled 22 for now because of resource issues with GH actions

steps:
- uses: actions/checkout@v4
Expand All @@ -70,10 +70,10 @@ jobs:
with:
xcode-version: latest

- name: Use Node.js 18
- name: Use Node.js 20
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: Check arch is x64 # arm64
run: |
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,22 @@ on:
workflow_call:

jobs:
windows-vs2019:
runs-on: windows-2019
windows-vs2022:
runs-on: windows-2022

strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 20]
target-node: [16, 18, 20, 22]
target-arch: [x64, arm64]

steps:
- uses: actions/checkout@v4

- name: Use Node.js 16
- name: Use Node.js 20
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20

- run: yarn install --ignore-engines

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false # prevent test to stop if one fails
matrix:
node-version: [12, 14, 16, 18, 20] # match patched node versions
node-version: [16, 18, 20, 22] # match patched node versions
os: [ubuntu-latest] # Skip macos-latest, windows-latest for now

runs-on: ${{ matrix.os }}
Expand Down
4 changes: 3 additions & 1 deletion Dockerfile.linux
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ RUN dnf upgrade -y
RUN dnf install -y \
gcc-toolset-10 glibc-headers kernel-headers \
make patch python2 \
python3
python3.12

RUN alternatives --set python3 /usr/bin/python3.12

# Install Node.js 20 and yarn
RUN curl -fsSL https://rpm.nodesource.com/setup_20.x | bash -
Expand Down
Loading