Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: allow to run tests in parallel #115

Merged
merged 10 commits into from
Oct 24, 2024
Merged

test: allow to run tests in parallel #115

merged 10 commits into from
Oct 24, 2024

Conversation

robertsLando
Copy link
Member

No description provided.

@robertsLando
Copy link
Member Author

After many tries seems that this is not possible at all and doesn't have any real benefit and there are still problems:

  • PNPM doesn't support concurrent installs
  • MACOS codesign utility doesn't allow concurrent signs commands

Another way could be to run npm run test:host && npm run test:18 && npm run test:20 in different steps

@robertsLando robertsLando merged commit f564a33 into main Oct 24, 2024
24 checks passed
@robertsLando robertsLando deleted the parallel-test-3 branch October 24, 2024 12:02
Comment on lines +15 to +17
matrix:
node-version: [18.x, 20.x]
os: [ubuntu-latest, windows-latest, macos-latest]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we also expanded the matrix based on the individual tests? That way, each test would run in it's own runner asynchronously, and would also make it easier to see which test failed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will not be beneficial as there will be too runners spawn and github has a limit on runners, you will end up having lot runners waiting

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know! What is the limit? We've not run into that limit here. Say the limit is 50, even if we hit the limit and had to wait, wouldn't that be faster?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the limit in macos runner images, I think they give you at most 2/3 macos runner for time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants