-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: allow to run tests in parallel #115
Conversation
After many tries seems that this is not possible at all and doesn't have any real benefit and there are still problems:
Another way could be to run |
matrix: | ||
node-version: [18.x, 20.x] | ||
os: [ubuntu-latest, windows-latest, macos-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if we also expanded the matrix based on the individual tests? That way, each test would run in it's own runner asynchronously, and would also make it easier to see which test failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will not be beneficial as there will be too runners spawn and github has a limit on runners, you will end up having lot runners waiting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know! What is the limit? We've not run into that limit here. Say the limit is 50, even if we hit the limit and had to wait, wouldn't that be faster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the limit in macos runner images, I think they give you at most 2/3 macos runner for time
No description provided.