-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] If renderInPlace
is true, destinationElement is ignored
#101
[BUGFIX] If renderInPlace
is true, destinationElement is ignored
#101
Conversation
@cibernox Thanks! It looks like there is a test failure as a result. |
I'll check it in a moment. |
@lukemelia Fixed. As I see it, the failing test was asserting the wrong thing. At least in my mental model I think that |
@cibernox I'm with you on that. |
The failures seem unrelated now 🤔 |
@lukemelia do you want me to track those errors in master? |
@cibernox If you have time, I would be even more appreciative of you than I am everytime I use ember-power-select! |
@lukemelia I'll do it tonight. Before I start, given that canary is 3.0.0, how do you feel about dropping support for Ember 1.13 and make 2.4 the first supported LTS? This is regardless of fixing CI, just thinking ahead. |
@cibernox I'm open to that. |
00bb8af
to
f2bc98a
Compare
@lukemelia Rebased & green |
Merged. Thank you, Miguel. Sent you an invite to have commit bit, too. |
Thanks! If you could release a new patch version I'll update it in EPS. |
@cibernox Released as 0.5.4 |
I found this because I had a component that used ember-wormhole internally like this:
and it did complain about
destinationElement
being null, when it wasn't necessary.