fix: plot board layers for kicad 8 (and later?) #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, plotting a board using the kicad 8 library would only render component footprints, all grouped in the bottom right corner. As of this snapshot, PcbDraw once again plots the appropriate mask/silkscreen layers. The primary mechanism is to reshape the version selection logic such that that newer versions which are backwards compatible should render without requiring any code changes in PcbDraw going forward. Upstream modifications that still require changes (such as the existing differences in handling kicad 5/6 from 7 & 8) have been changed to form non-default branches, such that if support for kicad 5 is dropped, it's clear what code ought to be deleted to excise the kicad-5-specific compatibility concerns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, plotting a board using the kicad 8 library would only render component footprints, all grouped in the bottom right corner. As of this snapshot, PcbDraw once again plots the appropriate mask/silkscreen layers.
The primary mechanism is to reshape the version selection logic such that that newer versions which are backwards compatible should render without requiring any code changes in PcbDraw going forward.
Upstream modifications that still require changes (such as the existing differences in handling kicad 5/6 from 7 & 8) have been changed to form non-default branches, such that if support for kicad 5 is dropped, it's clear what code ought to be deleted to excise the kicad-5-specific compatibility concerns.
I expect this change to address #172, #162 (the most recent comment, anyway), and #167.