Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code styles in feed list #4

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Conversation

wxiaoguang
Copy link
Collaborator

No description provided.

@silverwind
Copy link

I don't approve. See go-gitea#21432 (comment).

@wxiaoguang
Copy link
Collaborator Author

For a full context, copy some comments here.

Let's keep the discussion in main PR.


It's unnecessary. Most time the !important used is improper. We have discussed many times. Like this one:

And https://en.wikipedia.org/wiki/Occam's_razor "entities should not be multiplied beyond necessity"

Every element could have their proper styles accurately.


In most times, when !important is used, it means that there is some essential design problem in code, or something is wrongly used (like go-gitea#17866)

Gitea's frontend is messy, do not make it more messy.

@yardenshoham yardenshoham merged this pull request into yardenshoham:code Oct 15, 2022
@wxiaoguang wxiaoguang deleted the code branch October 15, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants