-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: implement smart wrapping for all contexts #140
Conversation
- default width for deno - make opts optional for clients - make opts.width optional for clients
I am a command-line jockey not a web guru. Is there an easy way of testing the hypothetical "browser" endpoint? I have written one but not having much luck testing it! (I'll push it anyway so visible.) |
- not added to conditional exports yet
I hacked around with the browser code importing URLs on |
PR #119 has a rollup configuration that works with the ESM variations, so moving forward rather than using the cjs like I did here. Moved back to draft while follow-up with that. |
I am closing this in favour of #143. I'll spin off separate PRs for the typings improvements and Deno terminal width. |
Problem
Solution
import
conditional exportThis PR takes a different approach to #139, which used import map to have two copies of dependencies.
This changes the main esm entry point to contain hybrid ESM/CommonJS imports. This won't affect usage from node but may affect some clients. This is probably a breaking change which needs to go in a semver major release?
To do
Out of scope