Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Fix for Prototype Pollution - huntr.dev #107

Closed
wants to merge 6 commits into from
Closed

Security Fix for Prototype Pollution - huntr.dev #107

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3de26e9
Fix Prototype Pollution
alromh87 Oct 17, 2020
e18b903
Merge pull request #1 from alromh87/master
JamieSlome Oct 19, 2020
432ea9e
Update index.ts
Oct 19, 2020
a970280
Amended fix to prevent polluting prototype instead of throwing error …
JamieSlome Oct 22, 2020
9c5ec13
Fixing CI/CD linting checks.
JamieSlome Oct 22, 2020
7c6fdda
Running regression test as a function call instead of expression.
JamieSlome Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,10 @@ class Y18N {
}

updateLocale (obj: Locale) {
if (this.locale === '__proto__') {
throw new Error('Prototype pollution attempt detected')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throwing an error doesn’t seem useful here; it seems like the proper fix would be to set a strong property instead of looking up the [[Prototype]].

}

if (!this.cache[this.locale]) this._readLocaleFile()

for (const key in obj) {
Expand Down