Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Ignore multiple spaces between arguments. #100

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Fix: Ignore multiple spaces between arguments. #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/tokenize-arg-string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,20 @@ module.exports = function (argString) {
if (Array.isArray(argString)) return argString

var i = 0
var prevC = null
var c = null
var opening = null
var args = []

for (var ii = 0; ii < argString.length; ii++) {
prevC = c
c = argString.charAt(ii)

// split on spaces unless we're in quotes.
if (c === ' ' && !opening) {
i++
if (!(prevC === ' ')) {
i++
}
continue
}

Expand Down
8 changes: 8 additions & 0 deletions test/tokenize-arg-string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
var tokenizeArgString = require('../lib/tokenize-arg-string')

require('chai').should()
var expect = require('chai').expect

describe('TokenizeArgString', function () {
it('handles unquoted string', function () {
Expand Down Expand Up @@ -37,4 +38,11 @@ describe('TokenizeArgString', function () {
args[1].should.equal('hello \'world\'')
args[2].should.equal('--bar=foo "bar"')
})

it('multiple spaces only counted in quotes', function () {
var args = tokenizeArgString('foo bar "foo bar"')
args[0].should.equal('foo')
expect(args[1]).equal('bar')
expect(args[2]).equal('foo bar')
})
})