Fix Boolean options with non boolean defaults #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this issue in minimist: https://github.com/substack/minimist/issues/44
It you have a boolean flag with a default to something that isn't a boolean. For example:
Then calling with
--foo
will result in{"_": [], "foo": [null, true]}
.I updated
setKey()
to avoid creating an array if the key inargv
is inflags.bools
. Previously, it only checked if the current value for the key inargv
was a Boolean, but that didn't consider the case when a non-Boolean is set by default.Note that setting a non-Boolean default for a Boolean key can be useful, as in the referenced issue, to find out if a key was explicitly set by the user in the CLI.