feat!: NaN can now be provided as a value for nargs, indicating "at least" one value is expected for array #251
+55
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces special handling of NaN, which yargs will use rather than 1 to indicate that an argument has a required value following the flag. BREAKING CHANGE: the narg count is now enforced when parsing arrays.
bcoe
changed the title
bcoe
changed the title
This was referenced Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces special handling of NaN, which yargs will use rather than 1 to indicate that
an argument has a required value following the flag.
BREAKING CHANGE: the narg count is now enforced when parsing arrays.
This is in reaction to mochajs/mocha#4196, yargs/yargs#1098, and yargs/yargs#1570. It will eliminate ambiguity in
requiresArgvs.,nargs =, by movingrequiresArgto using the specialNaNvalue fornargs.