Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added coerce option, for providing specialized argument parsing #42

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Aug 8, 2016

No description provided.

@bcoe bcoe merged commit 7b49cd2 into master Aug 8, 2016
@bcoe bcoe deleted the coerce branch August 8, 2016 06:28
@nexdrew
Copy link
Member

nexdrew commented Aug 8, 2016

Since a callback is used, I would expect yargs-parser to support asynchronous coercion, but it doesn't (yargs-parser is fully synchronous). Values given to the callback asynchronously are ignored.

Perhaps coerce functions should either return a value or throw an error to make it clear that coercion must be synchronous.

@nexdrew
Copy link
Member

nexdrew commented Aug 8, 2016

See #47

@maxrimue maxrimue mentioned this pull request Aug 9, 2016
10 tasks
@nexdrew nexdrew mentioned this pull request Aug 13, 2016
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants