Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: remove deprecated dependency lodas.assign #58

Closed
wants to merge 1 commit into from
Closed

feature: remove deprecated dependency lodas.assign #58

wants to merge 1 commit into from

Conversation

coderaiser
Copy link
Contributor

@coderaiser coderaiser commented Sep 28, 2016

When I install yargs-parser I see this warning:

npm WARN deprecated lodash.assign@4.2.0: This package is deprecated. Use Object.assign.

So I replaced lodash.assign with object-assign.

lodash documentation says:

This method mutates object and is loosely based on Object.assign.

@bcoe
Copy link
Member

bcoe commented Sep 30, 2016

@coderaiser thanks for bringing this to our attention, rather than pulling in a dependency I'm opting to simply implement this logic ourselves:

#59

Since we're only using this logic to override default values, we can keep the logic pretty simple.

Hope that this is just the first of many contributions 👍

@bcoe bcoe closed this Sep 30, 2016
@coderaiser
Copy link
Contributor Author

@bcoe Great, that's even better :).

@coderaiser coderaiser deleted the lodash.assign branch September 30, 2016 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants