refactor: rename flag

yarnpkg · Nov 11, 2023 · 4da62cf · 4da62cf
1 parent 47d7d7f
commit 4da62cf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/packages/acceptance-tests/pkg-tests-specs/sources/pnp-esm.test.ts b/packages/acceptance-tests/pkg-tests-specs/sources/pnp-esm.test.ts
@@ -1,7 +1,7 @@
-import {nodeUtils}                   from '@yarnpkg/core';
-import {Filename, npath, ppath, xfs} from '@yarnpkg/fslib';
-import {HAS_LOADER_CHAINING}         from '@yarnpkg/pnp/sources/esm-loader/loaderFlags';
-import {pathToFileURL}               from 'url';
+import {nodeUtils}                     from '@yarnpkg/core';
+import {Filename, npath, ppath, xfs}   from '@yarnpkg/fslib';
+import {HAS_LOADERS_AFFECTING_LOADERS} from '@yarnpkg/pnp/sources/esm-loader/loaderFlags';
+import {pathToFileURL}                 from 'url';
 
 const ifAtLeastNode21It = nodeUtils.major >= 21 ? it : it.skip;
 const ifAtMostNode20It = nodeUtils.major <= 20 ? it : it.skip;
@@ -779,7 +779,7 @@ describe(`Plug'n'Play - ESM`, () => {
   );
 
   // Tests /packages/yarnpkg-pnp/sources/esm-loader/fspatch.ts
-  (HAS_LOADER_CHAINING ? it : it.skip)(
+  (HAS_LOADERS_AFFECTING_LOADERS ? it : it.skip)(
     `should support loaders importing named exports from commonjs files`,
     makeTemporaryEnv(
       {

diff --git a/packages/yarnpkg-pnp/sources/esm-loader/loaderFlags.ts b/packages/yarnpkg-pnp/sources/esm-loader/loaderFlags.ts
@@ -9,4 +9,5 @@ export const WATCH_MODE_MESSAGE_USES_ARRAYS = major > 19 || (major === 19 && min
 export const HAS_LAZY_LOADED_TRANSLATORS = (major === 20 && minor < 6) || (major === 19 && minor >= 3);
 
 // https://github.com/nodejs/node/pull/43772
-export const HAS_LOADER_CHAINING = major > 19 || (major === 19 && minor >= 6);
+// TODO: Update the version range if it gets backported to v18.
+export const HAS_LOADERS_AFFECTING_LOADERS = major > 19 || (major === 19 && minor >= 6);