Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write new documentation pages. #7

Closed
arcanis opened this issue Feb 22, 2019 · 6 comments
Closed

Write new documentation pages. #7

arcanis opened this issue Feb 22, 2019 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@arcanis
Copy link
Member

arcanis commented Feb 22, 2019

Describe the user story

I'm a Yarn user and I want to learn more about its inner working.

Describe the solution you'd like

The missing pages from the documentation should be implemented.

@arcanis arcanis added enhancement New feature or request good first issue Good for newcomers labels Feb 22, 2019
@nickbalestra
Copy link

Before I open a new issues I thought was worth posting it here about "improving current documentation pages" as well.
Specifically, we have a migration page and could be good to add some sort of troubleshooting guide.

Here few example I was thinking of:

  • Undeclared peer dependency issues
  • Accessing in-zip path from scripts via yarn node (ie to set up git hooks)

In relation to documentation perhaps we could also improve the contributing page in berry by borrowing some content from https://yarnpkg.com/en/org/contributing/ and enriching it.

What are your thoughts in this direction?

@arcanis
Copy link
Member Author

arcanis commented Apr 30, 2019

Yup I agree. Mentioning the good first issue and help wanted tags in the contributing guide in particular is something I didn't think before but would make a ton of sense 👍

@onigoetz
Copy link

I'd like to help on this, is there a list of pages that are missing ?

@arcanis
Copy link
Member Author

arcanis commented May 21, 2019

(One problem is that the website is currently broken; waiting for gatsbyjs/gatsby#14208 and gatsbyjs/gatsby#14209 to be merged and released before I can fix it. As a short term fix you can set pnpFallbackMode: all in the .yarnrc file and it should work after a fresh yarn install)

We were starting to discuss it with @olingern: it would be good to write a "Migrating from v1" page within the "Getting started" section. There's already one in the "Advanced" section but it's more a troubleshooting page than an actual guide.

Apart from I think that we would benefit from a page detailing the TypeScript workflow (in Advanced, likely). It's already covered a bit with the "PnPify" page, but there are more options that we should list , such as ts-loader and fork-ts-checker-webpack-plugin (and make it easy to figure out which one to use depending on the case) cc @johnnyreilly

The "Contributing" page could be improved a bit; in particular to explain how to rebuild the website (it's just a yarn develop in packages/gatsby; one trick is that it requires a yarn install before because there are native dependencies that need to be built).

Finally I'd really like us to work a bit on the package page. It's currently hidden (it should be https://yarnpkg.github.io/berry/package?webpack but it seems broken at the moment; that's how hidden it is 😅). Ideally we should have the same features as on the current website (particularly the package listing view which is super-useful for us as maintainers) cc @Haroenv

@johnnyreilly
Copy link

Apart from I think that we would benefit from a page detailing the TypeScript workflow (in Advanced, likely). It's already covered a bit with the "PnPify" page, but there are more options that we should list , such as ts-loader and fork-ts-checker-webpack-plugin (and make it easy to figure out which one to use depending on the case) cc @johnnyreilly

Yup, as discussed in arcanis/pnp-webpack-plugin#10 I'm putting together some examples of how to work TypeScript / webpack with yarn PnP. Once I've got them in a good state I'd be happy to use that as a basis to provide some documentation.

Docs are the most important onboarding feature 😁

@arcanis
Copy link
Member Author

arcanis commented Jan 16, 2020

Lots of pages have been added since I opened this issue. Closing for now!

@arcanis arcanis closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants