chore(gatsby): adds support for PnP in test-require-error #14209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
added
the
status: awaiting reviewer response
|
@arcanis not exactly sure why this would cause the e2e test to fail, but it seems legitimate. Re-running the tests just to verify no issues. |
|
Everything is green but now it's #14208 that got a timeout - I guess it's an infra fail, right? |
DSchau
changed the title
wardpeet
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of
test-require-errorwas simply checking the error message to figure out whether the exception thrown was caused by the file not existing. This didn't work under PnP since we throw semantic errors (the message is different depending on the reason why the require call failed).Instead we should check for the
QUALIFIED_PATH_RESOLUTION_FAILEDcode, which means that the dependency check was successful but the resolver was unable to find a file on the disk that would match the specified request.Related Issues
Needed to test #14208 w/ PnP