Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the latest TS patch #1205

Merged
merged 7 commits into from
Apr 19, 2020
Merged

Updates to the latest TS patch #1205

merged 7 commits into from
Apr 19, 2020

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Apr 16, 2020

What's the problem this PR addresses?

typescript-eslint/typescript-eslint#1592

How did you fix it?

microsoft/TypeScript@bba19af

Test it with:

yarn set version from sources --branch 1205
yarn install

@regevbr
Copy link

regevbr commented Apr 16, 2020

So the patch doesn't really patch ts3.8 so the issue still persists.
Trying to install @next fails to apply the patch: Cannot apply hunk #1
@arcanis can you please advise?

@regevbr
Copy link

regevbr commented Apr 17, 2020

@arcanis is there something I can help with here?

@regevbr
Copy link

regevbr commented Apr 19, 2020

@arcanis I can confirm this now works well in windows with ts3.8! thanks!

@arcanis
Copy link
Member Author

arcanis commented Apr 19, 2020

Perfect, thanks! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants