fix(core): always call callback in DefaultStream._flush #2255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
DefaultStream._flush
doesn't call the callback if the stream isn't empty which, because node 15 waits for it, causes the event loop to become empty and the process exits early duringworkspaces foreach
callsNote that the tests catch this when they run under node 15 but I can't enable it because of #2232
Fixes #2214
Fixes #2074
How did you fix it?
Always call the callback.
Checklist