Add fsevents to plugin-compat README #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
I found that a handful of new cache packages were downloaded when moving from yarn v1 to v2 (although I had to compare the cache manually to find them, see #2465). After some digging, I found that they were being added by plugin-compat, although it wasn't immediately obvious where the
fsevents-patchfiles were coming from. Eventually I realized that it was also from plugin-compat, although the readme didn't mention it.How did you fix it?
I added
fseventsto the readme, and updated some of the links that were broken.I declined the version bump, not sure if that was the right thing for a readme update or not...
Checklist