Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests on Node.js v20 #5422

Closed
wants to merge 1 commit into from
Closed

ci: run tests on Node.js v20 #5422

wants to merge 1 commit into from

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented May 3, 2023

What's the problem this PR addresses?

Node.js v20 has been released so we should run tests on it.

v20.0.0 contained a bug that caused issues with ESM loaders which was fixed in v20.1.0 so we can now fully test it.

How did you fix it?

Updated the matrix.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from arcanis as a code owner May 3, 2023 16:17
@merceyz merceyz marked this pull request as draft May 3, 2023 16:28
@merceyz merceyz marked this pull request as ready for review May 4, 2023 20:18
@merceyz
Copy link
Member Author

merceyz commented May 4, 2023

@arcanis Could you update the list of required jobs?

@arcanis
Copy link
Member

arcanis commented May 16, 2023

Sorry, missed your PR - I'll close this one since it's superseded by #5445

@arcanis arcanis closed this May 16, 2023
@merceyz
Copy link
Member Author

merceyz commented Jun 5, 2023

This PR should land regardless of what happens to #5445 as this PR can be backported.

@merceyz merceyz deleted the merceyz/ci/node-20 branch June 24, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants